Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cluster local tls #1112

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jul 8, 2024

Part of: knative/serving#14375

Release Note

Add support for cluster-local-tls routes

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@knative-prow knative-prow bot requested review from KauzClay and skonto July 8, 2024 15:49
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2024
@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 8, 2024

/assign @izabelacg @ReToCode

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (b28a029) to head (defb126).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   93.96%   94.01%   +0.05%     
==========================================
  Files          11       11              
  Lines         712      719       +7     
==========================================
+ Hits          669      676       +7     
  Misses         22       22              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jul 9, 2024

Some unchanged files have header issues.

@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 9, 2024

Some unchanged files have header issues.

I'll do that in a separate PR - done #1114

@skonto
Copy link
Contributor

skonto commented Jul 10, 2024

LGTM waiting for @ReToCode and @izabelacg

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell (not knowing that much about contour), LGTM.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link

knative-prow bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e588e72 into knative-extensions:main Jul 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants