-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cluster local tls #1112
Add support for cluster local tls #1112
Conversation
/assign @izabelacg @ReToCode |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
+ Coverage 93.96% 94.01% +0.05%
==========================================
Files 11 11
Lines 712 719 +7
==========================================
+ Hits 669 676 +7
Misses 22 22
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Some unchanged files have header issues. |
I'll do that in a separate PR - done #1114 |
LGTM waiting for @ReToCode and @izabelacg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell (not knowing that much about contour), LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of: knative/serving#14375
Release Note