Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default TLS certificate shouldn't be applied to cluster local routes #1111

Merged

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jul 8, 2024

Release Note

Setting a `default-tls-secret` in `config-contour` no longer applies this secret to cluster local routes

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 8, 2024
Copy link

knative-prow bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from izabelacg and KauzClay July 8, 2024 14:56
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@dprotaso dprotaso force-pushed the fix-default-tls-secret branch from 76f52e9 to 5e96a65 Compare July 8, 2024 14:57
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (80ccaca) to head (5e96a65).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1111   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          11       11           
  Lines         712      712           
=======================================
  Hits          669      669           
  Misses         22       22           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 8, 2024

/assign @izabelacg

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@knative-prow knative-prow bot merged commit b28a029 into knative-extensions:main Jul 8, 2024
24 checks passed
@dprotaso dprotaso deleted the fix-default-tls-secret branch July 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants