-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syslog Support #21
Syslog Support #21
Conversation
|
||
if VERSION < v"0.4.0-dev+3587" | ||
include("enum.jl") | ||
end | ||
|
||
@enum LogLevel DEBUG INFO WARNING ERROR CRITICAL OFF | ||
@enum LogLevel OFF=-1 CRITICAL=2 ERROR WARNING INFO=6 DEBUG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better, and even though breaking, probably okay, as long as no one was depending on the order outside of this module. Will probably do a minor version bump.
Looks really good--thanks! |
Thanks for the feedback. It's also worth noting this only adds support for logging to syslog via UDP. Syslog also supports logging to a local socket and over TCP (something to look into adding in the future). |
f8ce4a6
to
ff675cf
Compare
ff675cf
to
9a782c6
Compare
@kmsquire I recently updated this PR, fixed a few julia 0.4 deprecation warnings and added a max message length attribute to the SysLog type, this allows you to truncate log messages. I was finding that my application was crashing on some large debug messages when trying to send them over the |
@kmsquire Any plans to merge this in? We're going to be keeping a fork at https://github.com/analyzere/Logging.jl so I have a vested interest in preventing these two from diverging too much :) |
Thanks for the bump. I've been working my way through issues in other packages, and haven't spent a lot of love here. |
No problem, I've seen the other things you've been doing, you're very busy. Thanks! |
@sbchisholm @DanielArndt I've added you both as collaborators here, so if there other things that you see that need attention, I'd love the help. My hopes/plans:
It seems that people use this package, so I think the first item is reasonable so that at least more people have access to fix things. That said, just moving it to JuliaLang doesn't guarantee that. For the others, I don't know if/when I will find the time. Like a lot of people, I'm a volunteer here, and my availability ebbs and flows. I'm also about to become a first-time father, so I should probably take care of at least the first item pretty soon... ;-) |
Fix log-level bug introduced by #21
"INFO"
or"DEBUG"
etc.).