Consistently handle child prefix/index as unsigned char, funsigned-char #251
+15
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop implicitly casting the child prefix/index to int. It can have high bits set thus get promoted to wildly incorrect value and cause chaos further on. Signed-off-by: Emil Velikov <[email protected]>
Stop implicitly casting the child prefix/index to int. It can have high bits set thus get promoted to wildly incorrect value and cause chaos further on. Signed-off-by: Emil Velikov <[email protected]>
Handful of places throughout the codebase rely on the data to be unsigned char. While most of those should be addressed now, one could argue that we should be switching the default and resolve the whole class of issues, instead of playing whack-a-mole by fixing individual bugs. Signed-off-by: Emil Velikov <[email protected]>
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #247 it addresses all the
s/int/unsigned char/instances that I could find.It also forces
chartounsigned char, since that's the majority(?) of our use case.NOTE: the PR is completely untested, hence marked as draft
Once the linked PR has landed and we have agreement if
-funsigned-charis something we'd really want, I will grab a few old and new kernels and do some testing.