Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Add OOG to PUSH ops #788

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add OOG to PUSH ops #788

merged 2 commits into from
Nov 6, 2023

Conversation

ClementWalter
Copy link
Member

Time spent on this PR: 0.15

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No OOG.

Resolves #787

What is the new behavior?

Revert on OOG.

@ClementWalter ClementWalter force-pushed the cw/push-ops-oog branch 2 times, most recently from 931331e to 48af806 Compare November 3, 2023 17:06
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (babe8d4) 70.61% compared to head (6f62812) 70.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   70.61%   70.37%   -0.24%     
==========================================
  Files          45       45              
  Lines        6562     6573      +11     
==========================================
- Hits         4634     4626       -8     
- Misses       1928     1947      +19     
Files Coverage Δ
src/kakarot/evm.cairo 100.00% <ø> (ø)
src/kakarot/instructions/push_operations.cairo 78.57% <81.25%> (-3.79%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix merged commit 5e18d51 into kkrt-labs:main Nov 6, 2023
6 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOG for push_operations
2 participants