Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ssj): move MockContractUpgradeable to separate file #1676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CreeptoGengar
Copy link

Time spent on this PR: 0.5 days

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, MockContractUpgradeableV1 is located in test_upgradeable.cairo file, which is no longer needed as mentioned in issue #1559.

Resolves #1559

What is the new behavior?

  • Moved MockContractUpgradeableV0 and MockContractUpgradeableV1 contracts to a new file mock_contract_upgradeable.cairo
  • Deleted test_upgradeable.cairo as it's no longer needed
  • All functionality remains intact and tests are preserved
  • Starknet-foundry can still resolve the contract class as it's used in test_kakarot_core.cairo

Move MockContractUpgradeableV0 and MockContractUpgradeableV1 contracts to new file
File contents moved to mock_contract_upgradeable.cairo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev(ssj): move MockContractUpgradeableV1 and delete test_upgradeable.cairo
1 participant