fix: do not store code hash for EOAs #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
approved these changes
Nov 28, 2024
enitrat
reviewed
Dec 3, 2024
There was a problem hiding this comment.
TLDR;
- All accounts have a codehash. If that account is an eoa it's simply keccak256("");
- You never want to have a disrepancy between the account's code and it's hash, thus it makes sense to write the code_hash in the same function as the account.
I think there's a small misconception between the code_hash of an account and the extcodehash in the way we handled this finding:
- All accounts have a code hash that is
keccak256(bytecode). If bytecode is empty, that code hash iskeccak256("")= EMPTY_CODE_HASH - The finding is valid when saying that account deployed with
deploy_externally_owned_accountwould have the wrong codehash
However I don't really agree with the way we handled this; I would rather have:
- Modified
Starknet.deploytoset_code_hash(EMPTY_CODE_HASH)(you're deploying a contract that doesn't have any code) - Replaced the
write_bytecodeof the account contract to write the code hash as well.
ClementWalter
pushed a commit
that referenced
this pull request
Dec 4, 2024
Overwrite fix to codehash done in #1644 Motivation: I prefer a solution that avoids having invalid states altogether. - All accounts have a code_hash set to keccak256("") when deployed - Any modification to the account's code will also modify it's code_hash - extcodehash simply check the account_exists = has_code_or_nonce or has_balance condition to know whether to return 0 or code_hash which is more inline with the spec. The `codehash` of an account is _never_ zero, the `extcodehash` is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
Code hash for eoa cannot be stored as they can change. Put the logic of 0 or empty code hash in function.