Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx to TRANSACTIONS list #1455

Closed

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Oct 1, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Added a legacy transaction to the list of transactions used in the rlp and eth_transaction tests.

The RLP decoding works as expected, but the eth_transaction test fails.

Resolves #

What is the new behavior?


This change is Reviewable

@ClementWalter ClementWalter force-pushed the cw/fix-rlp-encode-util branch 2 times, most recently from 0339d7f to 821f58a Compare October 2, 2024 11:59
@ClementWalter ClementWalter force-pushed the cw/fix-rlp-encode-util branch from 821f58a to a5d0ec9 Compare October 2, 2024 14:12
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
add WithOtherFields for TransactionReceipt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant