This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
dev: remove outside_execution checks & docs #1437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute_from_outside
purpose is that validate and execute are limited in functionalities. We could not run all EVM checks in validate , and our move to a "real" Starknet chain required a solution to handle the underlying starknet transaction fee for our users.Thus, we needed to implement a paymaster functionality.
All EVM tx rules validation are now handled in the execute part of a transaction to bypass the limitations of validate , and both these entrypoints have been disabled.
We use a fleet of relayer accounts to sponsor the Starknet cost of the transaction for our users, so that they don't have to worry about Starknet gas
For this, we implemented the execute_from_outside entrypoint as defined in SNIP-9
The outside_execution nonce is not signed, thus anyone can send a transaction to this entrypoint with any value for outside_execution and pass the first checks: it's indeed useless
However, there should not be a security risk: the EVM transaction sent
is signed by the EOA owner, and cannot be replayed
In the end: any checks on outside_execution is useless.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
This change is