Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use text-align over deprecated align attribute for td and th #349

Closed
wants to merge 1 commit into from

Conversation

popekim
Copy link

@popekim popekim commented Nov 29, 2023

align attribute is deprecated, and the text aligning of and elements should be done by text-align

align attribute is deprecated, and the text aligning of <td> and <th> elements should be done by text-align
@gjtorikian
Copy link
Collaborator

I'll let @kivikakk have final say here. The goal of this library is:

to model the upstream cmark-gfm as closely as possible in terms of code structure.

cmark-gfm toggles this alignment with an option, so that may also be needed here.

(Personally, damn the past and accept the future, LGTM)

@kivikakk
Copy link
Owner

Yes, I'd be happy to accept an option to toggle this; I don't particularly want to break executable spec compat (see CI) or change output for all existing users.

@kivikakk
Copy link
Owner

Closing since there's no option forthcoming! Thanks for your efforts here.

@kivikakk kivikakk closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants