Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents errors in tests while using migrations markers #71

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

kingbuzzman
Copy link
Owner

@kingbuzzman kingbuzzman commented Mar 26, 2024

We were using @pytest.mark.temporary_migration_module(module="....", app_label="app") but failing to use the migration_app_dir in the tests causing issues.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (fb8876c) to head (3fa477a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          12       12           
  Lines         610      610           
=======================================
  Hits          590      590           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingbuzzman kingbuzzman merged commit 4243b75 into master Mar 26, 2024
22 checks passed
@kingbuzzman kingbuzzman deleted the bugfix/fix-tests-not-using-fixture branch March 26, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants