Interactive Text-Based Adventure Game(Issue no. 24) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @debojit11 👋 We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon. |
king04aman
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks for your contribution, code is well-structured and demonstrates good use of OOPS principles. However, there are opportunities for improvement:
- Refactor
combat()to reduce code duplication for different opponents. - Create a helper function for clear inventory updates and displays.
- Use with statements for all file operations to ensure proper closing.
- Encapsulate game state in a dedicated class instead of using global variables.
|
👋 @king04aman 👋 🎉 You've just merged your pull request! We're excited to have you in our community. Keep up the fantastic contributions to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist
Summary
_This is a simple text-based adventure game where players explore rooms, collect items, and engage in combat with various opponents. Players can choose different paths, fight enemies like goblins and dragons, and manage an inventory of items such as swords and shields. The game features random encounters and decision-making, creating a unique experience each time it is played. This is the PR for the issue #24 _
Screenshot
Attach any relevant screenshots or GIFs here.
Live Project Link
Include a link to the live project here.