Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all the changes requested by you are made!!! #68

Closed
wants to merge 2 commits into from
Closed

all the changes requested by you are made!!! #68

wants to merge 2 commits into from

Conversation

harshgsharma1501
Copy link
Contributor

@harshgsharma1501 harshgsharma1501 commented Oct 19, 2024 •
edited
Loading

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

Please provide a brief summary here.

Screenshot

Attach any relevant screenshots or GIFs here.

Live Project Link

Include a link to the live project here.

@harshgsharma1501
Copy link
Contributor Author

Can you please please allow me to merge the files ? I have made the required changes.

king04aman
king04aman requested changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Consider adding README file for better clarity of project and usages.
  • Add requirements.txt which should contains required packages along with their versions and also runtime.txt
  • You dir structure isn't changed yet! Make sure all required files for your project should in project directory only, not like this:
    • ToDoAppTkInter
      • To_Do_AppTkInter.py
    • tasks.db
  • Make sure you have closed previous PR before opening new one to avoid duplicate labels and failed checks.

king04aman
king04aman reviewed Oct 19, 2024
View reviewed changes
Copy link
Owner

@king04aman king04aman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Changes From Previous Review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@king04aman king04aman king04aman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshgsharma1501 @king04aman