Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13.x] RHPAM-4817: Update backend Dockerfiles and configuration to Quarkus 2.13.8 #868

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

yurloc
Copy link
Member

@yurloc yurloc commented Oct 17, 2023

JIRA

- Update Dockerfiles.
- Explicitly allow all origins to fix a CORS issue caused by
  quarkusio/quarkus#33439.
@yurloc yurloc requested a review from dupliaka October 17, 2023 12:59
@kie-ci1
Copy link

kie-ci1 commented Oct 17, 2023

(tests) - optaweb-vehicle-routing job #13 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/1.13.x/job/pullrequest/job/optaweb-vehicle-routing.tests.optaweb-vehicle-routing/13/display/redirect

Test results:

  • PASSED: 248
  • FAILED: 0

Those are the test failures: none

See console log:

Console Logs [2023-10-17T13:10:29.433Z] [INFO] Will not upload any artifacts in CLI environment
[2023-10-17T13:10:29.433Z]
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] }
[2023-10-17T13:10:29.494Z] Deleting 1 temporary files
[Pipeline] // configFileProvider
[Pipeline] }
[Pipeline] // script
Post stage
[Pipeline] junit
[2023-10-17T13:10:29.576Z] Recording test results
[2023-10-17T13:10:31.909Z] [Checks API] No suitable checks publisher found.
[Pipeline] archiveArtifacts
[2023-10-17T13:10:31.923Z] Archiving artifacts
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Sonar analysis)
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] withEnv
[Pipeline] {
[Pipeline] script
[Pipeline] {
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (check space after build)
Stage "check space after build" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
[2023-10-17T13:10:35.241Z] + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/1.13.x/job/pullrequest/job/optaweb-vehicle-routing.tests.optaweb-vehicle-routing/13/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh

@dupliaka
Copy link
Member

LGTM

@yurloc yurloc changed the title RHPAM-4817: Update to Quarkus 2.13.8 [8.13.x] RHPAM-4817: Update to Quarkus 2.13.8 Oct 17, 2023
@mareknovotny mareknovotny added the backport-8.13.x-blue label for generating backport PR to 8.13.x-blue branch label Oct 18, 2023
@mareknovotny
Copy link
Member

thnx for the fix @yurloc

fyi @rgdoliveira, we probably need this for the build too, right?

@rgdoliveira
Copy link
Member

@mareknovotny TBH I don't know, I mean, I dont see any direct reference to Quarkus version in this PR, so maybe this can be merged only for RHPAM 7.13.5 and skipped from the respin? (cc @yurloc ).

Also we dont need this to be backported to 8.13.x-blue branch, as optaplanner projects were dropped from there.

@rgdoliveira rgdoliveira removed the backport-8.13.x-blue label for generating backport PR to 8.13.x-blue branch label Oct 23, 2023
@yurloc yurloc changed the title [8.13.x] RHPAM-4817: Update to Quarkus 2.13.8 [8.13.x] RHPAM-4817: Update backend Dockerfiles and configuration to Quarkus 2.13.8 Oct 27, 2023
@yurloc
Copy link
Member Author

yurloc commented Oct 27, 2023

@rgdoliveira The PR title may have been a bit confusing, sorry for that. I've updated it.

What this PR actually does is that it updates backend Dockerfiles and configuration (application.properties) to fix two bugs that were introduced by several Quarkus updates made this year and which only manifested now during QE tests.

Quarkus upgrades:

This PR is needed to make the QE CI pipeline green. @dupliaka please confirm.

@mareknovotny mareknovotny requested a review from pibizza October 31, 2023 14:17
Copy link

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

@mareknovotny mareknovotny merged commit ad1a92f into kiegroup:8.13.x Nov 6, 2023
7 checks passed
@yurloc yurloc deleted the quarkus-2.13.8 branch November 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants