Merge pull request #29 from khornberg/bug/bools

Version: 0.7.1 -> 0.7.2

setup.py

@@ -21,7 +21,7 @@ def read(*names, **kwargs):
 
 setup(
     name='octokitpy',
-    version='0.7.1',
+    version='0.7.2',
     license='MIT license',
     description='Python client for GitHub API',
     long_description='%s\n%s' % (

src/octokit/__init__.py

@@ -55,9 +55,16 @@ def _form_url(self, values, _url, params):
     def _get_data(self, kwargs, params):
         for param, value in params.items():
             if value.get('default') and not kwargs.get(param):
-                kwargs[param] = value.get('default')
+                kwargs[param] = self._get_parameter_for_type(value)
         return kwargs
 
+    def _get_parameter_for_type(self, param):
+        if param.get('type') == 'boolean' and param.get('default') == 'true':
+            return True
+        if param.get('type') == 'boolean' and param.get('default') == 'false':
+            return False
+        return param.get('default')
+
     def _data(self, data_kwargs, params, method):
         data = self._get_data(data_kwargs, params)
         if method == 'get':

tests/test_methods.py

@@ -86,6 +86,15 @@ def test_validate_enum_values(self):
             Octokit().issues.edit(owner='testUser', repo='testRepo', number=1, state='closeddddd')
         assert 'closeddddd is not a valid option for state; must be one of [\'open\', \'closed\']' == str(e.value)
 
+    def test_validate_boolean_values(self, mocker):
+        mocker.patch('requests.post')
+        Octokit().repos.create_deployment(owner='testUser', repo='testRepo', ref='abc123')
+        data = '{"auto_merge": true, "description": "\\"\\"", "environment": "none", "payload": "\\"\\"", "ref": "abc123", "task": "deploy"}'  # noqa E501
+        headers = {'Content-Type': 'application/json', 'accept': 'application/vnd.github.ant-man-preview+json'}
+        requests.post.assert_called_once_with(
+            'https://api.github.com/repos/testUser/testRepo/deployments', data=data, headers=headers
+        )
+
     def test_non_default_params_not_in_the_url_for_get_requests_go_in_the_query_string(self, mocker):
         mocker.patch('requests.get')
         params = {'page': 2, 'per_page': '30'}