Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): prevents warning that occurs when multitapping longpressable modifier keys #12964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jahorton
Copy link
Contributor

Fixes: #12963

User Testing

TEST_NAIJATYPE_CAPS_ON_ANDROID: Using Keyman for Android..

  1. Double-tap on the default-layer shift key and verify that:
    • No error or warning messages appear
    • The CAPS layer activates and holds, even after typing a couple of letters
  2. Triple-tap the default layer i key, verifying that results and that no errors or warnings occur.

TEST_EUROLATIN: Using Keyman for Android, verify that the keyboard's caps-lock behavior works properly.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 21, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 21, 2025
@jahorton jahorton changed the title fix(web): prevents multitap warning that occurs multitapping longpressable modifier keys fix(web): prevents warning that occurs when multitapping longpressable modifier keys Jan 21, 2025
@dinakaranr
Copy link

Test Results

I tested this issue with the attached "18.0.173-alpha-test-12964" build(21/01/2025) on Android 14(Physical Device). I'm sharing my observation here.

  • TEST_NAIJATYPE_CAPS_ON_ANDROID (Passed):
  1. Installed the "Keyman-18.0.173.apk" file from this PR build.
  2. Open the Keyman app.
  3. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  4. Installed the "NAIJATYPE" keyboard.
  5. Navigate to the Keyman edit notepad.
  6. Enter some letters using the "naijatype" keyboard.
  7. Double tap on the "Shift" key.
  8. Verified that no error & warning message appeared.
  9. Hold on to any cap key and then select the subkeys.
  10. Verified that the subkeys appeared
  11. Disable the caps layer by pressing the "Shift key"
  12. Triple-tap the default layer " i " key.
  13. Verified that no error & warning message appeared.
  14. Verified that the " ị " letter appeared.
    It works well.
  • TEST_EUROLATIN (Passed):
  1. Installed the "Keyman-18.0.173.apk" file from this PR build.
  2. Open the Keyman app.
  3. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  4. Double tap on the "Shift" key.
  5. Verified that no error & warning message appeared.
  6. Hold on to any cap key and then select the subkeys.
  7. Verified that the subkeys appeared.
    It works well.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug(web): warning during multitap handling on modifier keys with longpresses
3 participants