Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): don't crash if second transform is null #12860

Closed
wants to merge 1 commit into from

Conversation

ermshiperete
Copy link
Contributor

Fixes: #12494

User Testing

TEST_NOCRASH: follow the steps outlined in #12494 and verify that the crash no longer happens

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 6, 2025
@dinakaranr
Copy link

dinakaranr commented Jan 7, 2025

Test Results

I tested this issue with the attached "18.0.163-alpha-test-12860" build on the Andoird 14. Here is my observation.

  • TEST_NOCRASH (failed):
  1. Open the keyman app in the Android mobile app.
  2. Added EuroLatin keyboard.
  3. Added a sentence.
  4. Added letters in this order.
  5. Longpress g --> g̃,
  6. Longpress h --> ḥ,
  7. Longpress j --> ĵ,
  8. Flick down on c --> ',
  9. Flick down on v --> ",
  10. Here, an Error appeared.
    Please take a look at the attached video file(Android14_Keyman18.0.163-Alpha-Test-12860). Thank you.
    https://github.com/user-attachments/assets/9cafa3da-bd60-4ddf-9fad-2e4164d29590
    I tested this issue on the Android mobile. Please let me know where to test this issue in the web version. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Jan 7, 2025
@darcywong00
Copy link
Contributor

I got the same error. Here's the console log

       Failed to load resource: net::ERR_FILE_NOT_FOUND
@keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts:155 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'deleteLeft')
    at _SearchNode.buildDeletionEdges (@keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts:155:20)
    at @keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts:489:28
    at Array.map (<anonymous>)
    at _SearchSpace.addInput (@keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts:488:39)
    at ContextTracker.attemptMatchContext (@keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/correction/context-tracker.ts:487:37)
    at _ContextTracker.analyzeState (@keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/correction/context-tracker.ts:679:37)
    at @keymanapp/keyman/web/src/engine/predictive-text/worker-thread/src/main/predict-helpers.ts:185:48
    at Generator.next (<anonymous>)
    at blob:null/158e62a8-81fe-4436-9c40-0d5446118914:49:63
    at new Promise (<anonymous>)

@jahorton
Copy link
Contributor

jahorton commented Jan 8, 2025

I think this is a case where it's more important to examine why a null is appearing there in the first place. I'm looking into it.

@ermshiperete
Copy link
Contributor Author

Superseded by #12864

@jahorton jahorton deleted the fix/web/12494_undefined-deleteLeft branch January 10, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug(web): undefined reading 'deleteLeft' causing crash in Android app
4 participants