Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(windows): UI layout for update tab 💽 #12840

Draft
wants to merge 7 commits into
base: feat/windows/include-install-packages
Choose a base branch
from
Draft

feat(windows): UI layout for update tab 💽 #12840

wants to merge 7 commits into from
+139 −47

Conversation

rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Dec 18, 2024 •
edited
Loading

Convert the update tab table to use css grid instead of html tables.
The apply update tab button is greyed out unless there is a Keyboard or Keyman update available.

Review #12794 first

The next stage of #10045
Fixes: #10045

User Testing

TEST_UI_UPDATES_KBD

  1. Install the Keyman Attached to the PR.

  2. Download the version of sil_eurolatin attached to his PR.

  3. Double-click on the downloaded file in Windows Explorer to install the keyboard

  4. Open Keyman configuration

  5. Ensure the Keyboard is installed and check the version is xx

  6. Select the Update Tab on the left.

  7. Press the Check for Updates button

  8. The window form shall be updated with the new version of the keyboard available.

TEST_UI_UPDATES_KEYMAN

This test is a little tricky and needs a newer alpha build then this PR.
Note to self: I could force a new build with dummy PR to bump to a newer version than this which will allow for testing.

  1. Install the Keyman Attached to the PR.

  2. Open Keyman configuration

  3. In the tab check the Keyman version

  4. Select the Update Tab on the left.

  5. Press the Check for Updates button

  6. The window form shall be updated with the new version of Keyman Available.

@rc-swag rc-swag self-assigned this Dec 18, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Dec 18, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 18, 2024 •
edited
Loading

User Test Results

Test specification and instructions

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 18, 2024
@github-actions github-actions bot added the feat label Dec 18, 2024
@rc-swag rc-swag changed the base branch from master to epic/windows-updates December 18, 2024 06:23
@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(windows): UI layout for update tab feat(windows): UI layout for update tab 💽 Dec 18, 2024
@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
@rc-swag rc-swag modified the milestones: A18S18, A18S19 Jan 6, 2025
@rc-swag
feat(windows): disable apply updated now if no updates
6b938e1 
Disable the apply update now if no updates are available.

Fixes: #12840
@keymanapp-test-bot keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Jan 7, 2025
@rc-swag
chore(windows): Merge branch 'epic/windows-updates' into feat/windows…
f9640d1 
…/ui-layout-for-update-tab

# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
#     Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
#     Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
@rc-swag rc-swag mentioned this pull request Jan 9, 2025
Open
@rc-swag rc-swag changed the base branch from epic/windows-updates to feat/windows/include-install-packages January 9, 2025 05:57
@rc-swag rc-swag marked this pull request as ready for review January 9, 2025 06:15
@rc-swag rc-swag requested a review from ermshiperete as a code owner January 9, 2025 06:15
@dinakaranr
Copy link

dinakaranr commented Jan 9, 2025 •
edited
Loading

Test Results

I tested this issue with the attached "18.0.153-alpha-test-12840" build on Windows 10. Here is my observation.

  • TEST_UI_UPDATES_KBD (Passed):
  1. Install Keyman attached the "18.0.153-alpha-test-12840" PR build.
  2. Install the SIL_Euro_Latin 3.0.2 version keyboard.
  3. Installed the Gff_Amharic 6.0.4 version keyboard.
  4. Open the Keyman Configuration dialog.
  5. Navigate to the "Keyboard Layouts tab".
  6. Verified that the installed keyboard shows an older version.
  7. Navigate to the "Update" tab.
  8. Press the "Check for new updates" button.
  9. Verified that the newer version appeared in the "Updated component" column.
    The UI looks good. Thank you.
  • TEST_UI_UPDATES_KEYMAN (Passed):
  1. Install Keyman attached the "18.0.153-alpha-test-12840" PR build.
  2. Open the Keyman Configuration dialog.
  3. Navigate to the "Update" tab.
  4. Press the "Check for new updates" button.
  5. Verified that the newer version appeared on the "Updated component" column for Keyman.
  6. Verified that the keyman's latest version is 18.0.164
  7. The UI looks good. Thank you.

Notes:
Other Observations about this feature:
a) "Apply update now" and "Check for new updates" buttons appeared one by one. There is no space between buttons.
b) The vertical bar always appears when maximizing the dialog too. if there is no update available.
c) The "Apply update now" button is enabled when the select box is unchecked. It needs to grey out when unchecked.
d) The "Update Keyman Components Available" dialog appears if the older Keyman version has been installed. Hence, the updates are displayed in two different ways.
e) Older keyboard updates are not available in the update tab.
f) Keyman does not upgrade to a newer version after clicking the "Apply update now" button. Here, The update tab is automatically refreshed.
g) The "Keep in Touch" page was not present in this release. Is this anticipated behavior right now?

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 9, 2025
@rc-swag rc-swag marked this pull request as draft January 9, 2025 12:59
@dinakaranr
Copy link

Hi, I am seeing this issue when testing the PR 12840 using the "18.0.153-alpha-test-12840" build on the Windows 10.
Crash appears when uninstalling the keyboard if the keyboard has a new update.

Steps to reproduce:

  1. Install Keyman attached the "18.0.153-alpha-test-12840" PR build.
  2. Installed the Gff_Amharic 3.1.1 version keyboard.
  3. Open the Keyman Configuration dialog.
  4. Navigate to the "Keyboard Layouts tab".
  5. Verified that the installed keyboard shows an older version.
  6. Navigate to the "Update" tab.
  7. Press the "Check for new updates" button.
  8. Verified that the newer version appeared in the "Updated component" column.
  9. Navigate to the "Keyboard Layouts" tab and uninstall the GFF Amharic keyboard.
    Actual Results: Here, A crash dialog appeared on the desktop window.
    Thank you.
    https://github.com/user-attachments/assets/3a1be582-899e-4c68-8689-1c3cb8093cf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete Awaiting requested review from ermshiperete ermshiperete is a code owner

Assignees

@rc-swag rc-swag

Labels
common/ epic-windows-updates feat has-user-test oem/fv/windows/ oem/fv/ oem/ windows/config/ windows/engine/ windows/
Projects
Keyman
Status: In Progress
Milestone
A18S19
Development

Successfully merging this pull request may close these issues.
3 participants
@rc-swag @dinakaranr @darcywong00