Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(common/web): unit tests for element-string #12811

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

markcsinclair
Copy link
Contributor

Unit tests for kmx/kmx-plus/element-string.ts

See #9052

@keymanapp-test-bot skip

@markcsinclair markcsinclair self-assigned this Dec 9, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 9, 2024
@github-actions github-actions bot added common/ common/web/ test Any acceptance test issue web/ labels Dec 9, 2024
@markcsinclair markcsinclair added web/ test Any acceptance test issue and removed web/ test Any acceptance test issue labels Dec 9, 2024
@markcsinclair markcsinclair marked this pull request as draft December 9, 2024 11:51
@github-actions github-actions bot added web/ and removed web/ labels Dec 9, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@darcywong00 darcywong00 added this to the A18S19 milestone Jan 6, 2025
@github-actions github-actions bot added web/ and removed web/ labels Jan 6, 2025
@github-actions github-actions bot added web/ and removed web/ labels Jan 6, 2025
@markcsinclair
Copy link
Contributor Author

markcsinclair commented Jan 6, 2025

ElemElement.isEqual() and ElementStrings.isEqual() fail if they are tested with cloned StrsItems internally, as StrsItem lacks an isEqual() method that should then be used in ElemElement.isEqual().

  isEqual(a: StrsItem): boolean {
    return a.value === this.value && a.char === this.char;
  }

See issue #12867 and PR #12868

@github-actions github-actions bot added web/ and removed web/ labels Jan 6, 2025
@github-actions github-actions bot added web/ and removed web/ labels Jan 9, 2025
@github-actions github-actions bot added web/ and removed web/ labels Jan 9, 2025
@github-actions github-actions bot added web/ and removed web/ labels Jan 9, 2025
@github-actions github-actions bot added web/ and removed web/ labels Jan 9, 2025
@markcsinclair markcsinclair marked this pull request as ready for review January 9, 2025 14:19
@github-actions github-actions bot added web/ and removed web/ labels Jan 9, 2025
@markcsinclair
Copy link
Contributor Author

Ready for review. Two fixes will be needed to cover the issues addressed by skipped tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common/web/ common/ test Any acceptance test issue web/
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants