More gen 22: Flow coverage exploration (remade) #9685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
changed the base branch from
master
to
nojima/DESKTOP-more-gen-2-2
3 tasks
|
@keybase/react-hackers this is ready |
buoyad
approved these changes
Nov 27, 2017
| @@ -423,7 +424,7 @@ function* _chatInboxFailedSubSaga(params) { | |||
| break | |||
| } | |||
| case RPCChatTypes.localConversationErrorType.otherrekeyneeded: { | |||
| const rekeyers = error.rekeyInfo.rekeyers | |||
| const rekeyers = (error.rekeyInfo && error.rekeyInfo.rekeyers) || [] | |||
| yield Saga.put(ChatGen.createUpdateInboxRekeyOthers({conversationIDKey, rekeyers})) | |||
There was a problem hiding this comment.
does this need to run if rekeyers is empty?
There was a problem hiding this comment.
unclear, i don't want things to really logically change so lets keep it for now
| onHotkey: cmd => { | ||
| _onSelectNext: (rows: Array<Inbox.RowItemSmall | Inbox.RowItemBig>, direction: -1 | 1) => | ||
| dispatch( | ||
| ChatGen.createSelectNext({rows: rows.map(r => ({conversationIDKey: r.conversationIDKey})), direction}) |
There was a problem hiding this comment.
Do we need this map? if rows is already covariant with what createSelectNext wants?
There was a problem hiding this comment.
i think we should only send what we need and likely the answer is to make that type exact
chrisnojima
added a commit
that referenced
this pull request
Nov 27, 2017
* WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * pr feedback * More gen 3 - profile generated 100% (#9427) * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * More Gen 4: Update rpc call typing (#9459) * WIP * WIP * Fix requestInfo typing * WIP * WIP * WIP * WIP * WIP * mark props as readonly * fix extra param * More gen 6: Push (5 was abandoned) (#9499) * gen push * More gen 7: Search (#9500) * gen search * More gen 8 : app (#9501) * WIP * gen app * More gen 9 - Dev + Devices (#9505) * gen dev * gen devices * More gen 10: Gen favorites (#9506) * gen favorite * fix payload type * More gen 11: gregor (#9507) * gen gregor * More gen 12: Gen notifications (#9509) * gen notifications * WIP * More gen 13: pgp gen (#9510) * pgp gen * More Gen 14: pinentry gen (#9511) * pinentry gen * More gen 15 - settings gen (#9519) * settings gen * More gen 16 - signup (#9524) * signup gen * plumb though clearDeviceNameError * More gen 17 - tracker (#9536) * WIP * WIP * WIP * flowtype selectors * WIP * WIP * WIP * use s instead of state for helpers * fix type * exports at the bottom * ignore bad usernames in reducer * More Gen 18 : unlock folders (#9543) * WIP * WIP * WIP * More gen 19: split chat types/constants (#9548) * split chat types/constants * More gen 20: Split types/constants (#9549) * split config * split dev * split devices * plan billing * split entities * split engine * remove bindActionCreators and fixup some issues * More Gen 21: splitting the rest of the stores (#9552) * split gregor * split login * split notifications * pgp * split pinentry * split profile * split push * split route-tree * split settings * split signup * split unlock folders * split waiting * fix buffer issue in mobile * More gen 22: Flow coverage exploration (remade) (#9685) * remake on top of squished 21 * rerun protocol * merge base (#9686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced #9575 . See that for comments