Add declaration of ICAL var #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kewisch
requested changes
Jul 13, 2021
| @@ -54,7 +54,8 @@ | |||
| "node": ">=10" | |||
| }, | |||
| "scripts": { | |||
| "test": "grunt test-node" | |||
| "test": "grunt test-node", | |||
| "prepare": "grunt" | |||
There was a problem hiding this comment.
prepare script is run by npm when installing from git sources as well as before npm publish - this means when install this fork without publishing to npm repo the code is built at install.
Closed
|
Hi, any updates on this topic? |
kewisch
added a commit
that referenced
this pull request
Jan 5, 2022
This was referenced Jan 6, 2022
This was referenced Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the module to not crash when used from nodejs
This shouldnt cause any problems with usage in the browser
Similar to
#449
#329