Move httpx monkeypatching to a lower layer to allow recording request generated by auth flows. #742
Conversation
… generated by auth flows. Should fix kevin1024#684.
|
I think someone needs to push some buttons to get CI approved. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 90.63% 90.47% -0.16%
==========================================
Files 28 28
Lines 1794 1796 +2
Branches 268 322 +54
==========================================
- Hits 1626 1625 -1
- Misses 133 135 +2
- Partials 35 36 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| with vcr.use_cassette(yml): | ||
| with do_request() as client: | ||
| client("GET", url, auth=AuthWithExtraRequest()) |
There was a problem hiding this comment.
The default value for follow_redirects is False on httpx client.
I think if you call the client with client("GET", url, auth=AuthWithExtraRequest(), follow_redirects=True) we don't need to overwrite a private method.
There was a problem hiding this comment.
I don't really understand what you wrote. If you think something else works please try it.
|
Also fixed in #784 |
|
I suggest we close this one in view of #784 |
|
Looks like #784 got merged |
Not sure if i wrote the test correctly but that test suite is way over my head.
I would like to note that the monkeypatching should be moved even lower but then there's some complicated redirect handling that I can't untangle.
Should fix #684.