Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persisters/filesystem_cached: Add file-based persister with cache #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gioele
Copy link

@gioele gioele commented Feb 14, 2021

This persister keeps a cache of cassettes, to avoid the overhead of constantly serializing and deserializing unchanged cassettes.

This is especially useful when no changes to the cassette are expected, for example when running testsuites with mode=none.

In a testsuite with hundreds of calls backed from YAML cassettes with 10k responses, the use of this persister saves various minutes.

This persister keeps a cache of cassettes, to avoid the overhead of
serializing and deserializing unchanged cassettes.

This is especially useful when no changes to the cassette are expected,
for example when running testsuites with `mode=none`.
@codecov-io
Copy link

codecov-io commented Feb 14, 2021

Codecov Report

Merging #576 (d6ed6e0) into master (6e04003) will increase coverage by 1.05%.
The diff coverage is 78.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   89.01%   90.06%   +1.05%     
==========================================
  Files          24       27       +3     
  Lines        1539     1742     +203     
  Branches      212      243      +31     
==========================================
+ Hits         1370     1569     +199     
+ Misses        139      135       -4     
- Partials       30       38       +8     
Impacted Files Coverage Δ
vcr/persisters/filesystem_cached.py 0.00% <0.00%> (ø)
vcr/stubs/aiohttp_stubs.py 94.30% <88.05%> (ø)
vcr/stubs/httpx_stubs.py 97.80% <97.80%> (ø)
vcr/cassette.py 97.15% <100.00%> (+0.98%) ⬆️
vcr/config.py 95.00% <100.00%> (+0.03%) ⬆️
vcr/patch.py 89.41% <100.00%> (+5.04%) ⬆️
vcr/record_mode.py 100.00% <100.00%> (ø)
vcr/serializers/jsonserializer.py 100.00% <100.00%> (ø)
vcr/serializers/yamlserializer.py 77.77% <0.00%> (-22.23%) ⬇️
vcr/migration.py 74.48% <0.00%> (-2.05%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79a06f...d6ed6e0. Read the comment docs.

Copy link
Collaborator

@colonelpanic8 colonelpanic8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't imported or tested anywhere

@kevin1024 kevin1024 force-pushed the master branch 3 times, most recently from df3997c to 34d5384 Compare June 26, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants