Keep the same request method when following redirects for non 303 responses in httpx #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 89.41% 83.98% -5.43%
==========================================
Files 24 26 +2
Lines 1549 1705 +156
Branches 216 239 +23
==========================================
+ Hits 1385 1432 +47
- Misses 135 238 +103
- Partials 29 35 +6
Continue to review full report at Codecov.
|
kestutisbalt
changed the title
2m
reviewed
Aug 18, 2020
vcr/stubs/httpx_stubs.py
Outdated
| @@ -108,7 +108,8 @@ def _play_responses(cassette, request, vcr_request, client, kwargs): | |||
| if not next_url: | |||
| break | |||
|
|
|||
| vcr_request = VcrRequest("GET", next_url, None, dict(response.headers)) | |||
| method = request.method if response.status_code != 303 else "GET" | |||
There was a problem hiding this comment.
Its tricky to know what would be the best logic here because it is not strictly mandated by the HTTP spec.
However according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Redirections the only status code that always changes to GET method is 303. So this LGTM!
| @@ -108,7 +108,11 @@ def _play_responses(cassette, request, vcr_request, client, kwargs): | |||
| if not next_url: | |||
| break | |||
|
|
|||
| vcr_request = VcrRequest("GET", next_url, None, dict(response.headers)) | |||
| # Even though 302 shouldn't change request's method, browsers like Chromium | |||
There was a problem hiding this comment.
why does what browsers do here matter?
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c to
34d5384
Compare
|
I suggest we close this one in view of #784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request method should be kept the same whenever redirect is not 302 and 303