Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth for api + upgrade to 0.65.0 #8

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Oct 30, 2024

Pull Request Title: oauth for api + upgrade to 0.65.0

Description:

Motivation:

The primary motivation for this pull request is to upgrade the project to version 0.65.0 and streamline the OAuth2 proxy configuration for the API. By doing so, we aim to enhance the security and maintainability of the project.

Changes:

  1. Version Upgrade:

    • Updated the chart version from 0.64.0 to 0.65.0 in charts/hub/Chart.yaml.
  2. Simplified OAuth2 Configuration:

    • Removed redundant OAuth2 proxy ingress configurations from charts/hub/templates/kerberos-hub/hub-frontend-demo.yaml and charts/hub/templates/kerberos-hub/hub-frontend.yaml.
    • Eliminated unnecessary annotations related to OAuth2 proxy in the frontend ingress configurations.

Benefits:

  • Security Enhancement: Streamlining the OAuth2 proxy configuration reduces potential misconfigurations and security vulnerabilities.
  • Maintainability: Simplifying the ingress configurations makes the codebase easier to understand and maintain.
  • Consistency: Ensuring consistent and minimal configuration across different environments.

Overall, these changes contribute to a more secure, maintainable, and consistent project setup.

@cedricve cedricve merged commit fb9c0d1 into main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant