Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Motivation
The current setup for handling preflight CORS requests in our Kubernetes ingress controller involves using a server snippet to return a 200 status code for OPTIONS requests. This approach has been functional, but it adds complexity and potential maintenance overhead to our configuration.
Changes Made
hub-api.yaml
that was handling OPTIONS requests.--skip-auth-preflight=true
flag to thehub-oauth2-proxy.yaml
configuration.Benefits
--skip-auth-preflight
flag in OAuth2 Proxy allows for more efficient handling of preflight requests, potentially improving performance and reducing latency.Overall, these changes aim to streamline our configuration and make our system more robust and maintainable.