Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try out --skip-auth-preflight=true #13

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Oct 31, 2024

Pull Request Description

Motivation

The current setup for handling preflight CORS requests in our Kubernetes ingress controller involves using a server snippet to return a 200 status code for OPTIONS requests. This approach has been functional, but it adds complexity and potential maintenance overhead to our configuration.

Changes Made

  1. Chart Version Update: Incremented the chart version from 0.69.0 to 0.70.0 to reflect these changes.
  2. Ingress Configuration:
    • Removed the server snippet from hub-api.yaml that was handling OPTIONS requests.
  3. OAuth2 Proxy Configuration:
    • Added the --skip-auth-preflight=true flag to the hub-oauth2-proxy.yaml configuration.

Benefits

  • Simplified Configuration: By removing the server snippet, the ingress configuration is simplified, making it easier to maintain and understand.
  • Improved Performance: Leveraging the --skip-auth-preflight flag in OAuth2 Proxy allows for more efficient handling of preflight requests, potentially improving performance and reducing latency.
  • Enhanced Security: Reducing custom server configurations minimizes the risk of misconfigurations or security vulnerabilities.

Overall, these changes aim to streamline our configuration and make our system more robust and maintainable.

@cedricve cedricve merged commit c70cf7f into main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant