Parse and resolve ValueReferences #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellerkindt
changed the title
kellerkindt
force-pushed
the
valuereferences
branch
from
8eb92fd to
f4fa8ea
Compare
TLDR: deny copyleft, deny unknown, allow only MIT, Apache-2.0 and BSD-3-Clause
kellerkindt
force-pushed
the
valuereferences
branch
from
b155557 to
f3b4d8c
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueReferences are the constants of ASN.1. With this PR constant definitions in ASN.1 are parsed. The
Model<Asn>type has been split intoModel<Asn<Unresolved>>(which is now returned after parsing theTokenizerstream) andModel<Asn<Resolved>>which is required for the.to_rust()conversion. The functionModel::<Asn<Unresolved>>::try_resolve(&self) -> Result<Model<Resolved>, _>transforms the model by replacing VR-occurances with their declared value.TODOS remaining
This PR changes public API and thus is a breaking change in this regard.
A version bump toNo. 4: "Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable."0.3.0is therefore required by the semantic versioning guidelines