Fixed NEWNEWS wildmat bug. Fixed HeaderDateParser tests. Updated pack…

…ages. (#10)
keimpema · Oct 26, 2019 · a68dedd · a68dedd
1 parent fe6ae0f
commit a68dedd
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/Usenet/Nntp/NntpClient.rfc3977.cs b/Usenet/Nntp/NntpClient.rfc3977.cs
@@ -330,7 +330,7 @@ public NntpGroupsResponse NewGroups(NntpDateTime sinceDateTime) =>
         /// posted or received since this date and time.</param>
         /// <returns>A multi-line response containing a list of message-ids.</returns>
         public NntpMultiLineResponse NewNews(string wildmat, NntpDateTime sinceDateTime) =>
-            connection.MultiLineCommand($"NEWNEWS {sinceDateTime}", new MultiLineResponseParser(230));
+            connection.MultiLineCommand($"NEWNEWS {wildmat} {sinceDateTime}", new MultiLineResponseParser(230));
 
 
         /// <summary>

diff --git a/Usenet/Usenet.csproj b/Usenet/Usenet.csproj
@@ -14,17 +14,17 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="GitVersionTask" Version="4.0.0">
+    <PackageReference Include="GitVersionTask" Version="5.0.1">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
     <PackageReference Include="LibLog" Version="5.0.6">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
-    <PackageReference Include="Microsoft.Extensions.FileProviders.Abstractions" Version="2.2.0" />
-    <PackageReference Include="System.Collections.Immutable" Version="1.5.0" />
+    <PackageReference Include="Microsoft.CSharp" Version="4.6.0" />
+    <PackageReference Include="Microsoft.Extensions.FileProviders.Abstractions" Version="3.0.0" />
+    <PackageReference Include="System.Collections.Immutable" Version="1.6.0" />
     <PackageReference Include="System.Net.Security" Version="4.3.2" />
   </ItemGroup>
 

diff --git a/UsenetTests/Nntp/Parsers/HeaderDateParserTests.cs b/UsenetTests/Nntp/Parsers/HeaderDateParserTests.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using Usenet.Nntp.Parsers;
 using Xunit;
 
@@ -53,7 +54,7 @@ public void ObsoleteTwoDigitYearBeforeCurrentDateShouldBeParsedCorrectly()
         {
             DateTimeOffset yesterday = new DateTimeOffset(DateTime.UtcNow.Date.AddDays(-1), TimeSpan.Zero);
             DateTimeOffset expectedDate = yesterday;
-            string headerValue = $"{yesterday:dd MMM yy HH:mm:ss} +0000";
+            string headerValue = yesterday.ToString("dd MMM yy HH:mm:ss", CultureInfo.InvariantCulture) + " +0000";
             DateTimeOffset actualDate = HeaderDateParser.Parse(headerValue).GetValueOrDefault();
             Assert.Equal(expectedDate, actualDate);
         }
@@ -63,7 +64,7 @@ public void ObsoleteTwoDigitYearAfterCurrentDateShouldBeParsedCorrectly()
         {
             DateTimeOffset tomorrow = new DateTimeOffset(DateTime.UtcNow.Date.AddDays(+1), TimeSpan.Zero);
             DateTimeOffset expectedDate = tomorrow.AddYears(-100);
-            string headerValue = $"{tomorrow:dd MMM yy HH:mm:ss} +0000";
+            string headerValue = tomorrow.ToString("dd MMM yy HH:mm:ss", CultureInfo.InvariantCulture) + " +0000";
             DateTimeOffset actualDate = HeaderDateParser.Parse(headerValue).GetValueOrDefault();
             Assert.Equal(expectedDate, actualDate);
         }
@@ -73,7 +74,7 @@ public void ObsoleteTwoDigitYearOnCurrentDateShouldBeParsedCorrectly()
         {
             var today = new DateTimeOffset(DateTime.UtcNow.Date, TimeSpan.Zero);
             DateTimeOffset expectedDate = today;
-            string headerValue = $"{expectedDate:dd MMM yy HH:mm:ss} +0000";
+            string headerValue = expectedDate.ToString("dd MMM yy HH:mm:ss", CultureInfo.InvariantCulture) + " +0000";
             DateTimeOffset actualDate = HeaderDateParser.Parse(headerValue).GetValueOrDefault();
             Assert.Equal(expectedDate, actualDate);
         }

diff --git a/UsenetTests/UsenetTests.csproj b/UsenetTests/UsenetTests.csproj
@@ -9,9 +9,9 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.FileProviders.Embedded" Version="2.2.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.0.1" />
-    <PackageReference Include="Moq" Version="4.10.1" />
+    <PackageReference Include="Microsoft.Extensions.FileProviders.Embedded" Version="3.0.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.3.0" />
+    <PackageReference Include="Moq" Version="4.13.1" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
       <PrivateAssets>all</PrivateAssets>