Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: facets values "dancing" and Only/All button is not working #2489

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: facets values "dancing" and Only/All button is not working #2489

wants to merge 3 commits into from
+216 −189

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Nov 14, 2024

Closes #2488

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 4:31pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 14, 2024
@dosubot dosubot bot added Bug Something isn't working UI User interface related issues labels Nov 14, 2024
shahargl
shahargl previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@Kiryous
Merge branch 'main' into fix/2488-facets-values-dancing
db49886 
# Conflicts:
#	keep-ui/app/alerts/alert-table-alert-facets.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: facets values "dancing" and Only/All button is not working correctly
3 participants
@Kiryous @shahargl @talboren