Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runbooks queried from GitHub and Gitlab #2104

Closed
wants to merge 103 commits into from

Conversation

Mubashirshariq
Copy link
Contributor

@Mubashirshariq Mubashirshariq commented Oct 7, 2024

Closes #1780
/claim #1780

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Mubashir Shariq and others added 23 commits September 21, 2024 18:55
fix:runbooks intergation access token issue
refactor: moved the entire runbook fetching logic to backend and added new runbook tag
refactor: modified the styles of the runbook page
Copy link

vercel bot commented Oct 7, 2024

@Mubashirshariq is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

@Mubashirshariq Mubashirshariq marked this pull request as draft October 7, 2024 08:58
@Mubashirshariq Mubashirshariq changed the title Feat/runbook Feat/runbooks queried from github and gitlab Oct 7, 2024
@Matvey-Kuk
Copy link
Contributor

Matvey-Kuk commented Oct 20, 2024

I didn’t fully understand this part. Could you provide more context on how we are currently linking or associating the runbook with the incident?

I quite don't understand the question. The linking between incident and a runbook is expected to be added by this PR. There is many-many link expected. If I as a user link runbook to the incident, I expect to see the link from the incident page side as well.

@rajesh-jonnalagadda
Copy link
Contributor

I didn’t fully understand this part. Could you provide more context on how we are currently linking or associating the runbook with the incident?

I quite don't understand the question. The linking between incident and a runbook is expected to be added by this PR. There is many-many link expected. If I as a user link runbook to the incident, I expect to see the link from the incident page side as well.

Screenshot from 2024-10-20 21-01-03
you mean this functionality for runbook too.

@rajesh-jonnalagadda
Copy link
Contributor

I didn’t fully understand this part. Could you provide more context on how we are currently linking or associating the runbook with the incident?

I quite don't understand the question. The linking between incident and a runbook is expected to be added by this PR. There is many-many link expected. If I as a user link runbook to the incident, I expect to see the link from the incident page side as well.

Screenshot from 2024-10-20 21-01-03 you mean this functionality for runbook too.

^^

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 23, 2024
@rajesh-jonnalagadda
Copy link
Contributor

I didn’t fully understand this part. Could you provide more context on how we are currently linking or associating the runbook with the incident?

I quite don't understand the question. The linking between incident and a runbook is expected to be added by this PR. There is many-many link expected. If I as a user link runbook to the incident, I expect to see the link from the incident page side as well.

Screenshot from 2024-10-20 21-01-03 you mean this functionality for runbook too.

@Matvey-Kuk ^^

@Mubashirshariq
Copy link
Contributor Author

I didn’t fully understand this part. Could you provide more context on how we are currently linking or associating the runbook with the incident?

I quite don't understand the question. The linking between incident and a runbook is expected to be added by this PR. There is many-many link expected. If I as a user link runbook to the incident, I expect to see the link from the incident page side as well.

Screenshot from 2024-10-20 21-01-03 you mean this functionality for runbook too.

@Matvey-Kuk
All the other things are done only thing that is pending is incident one could you please provide some clarifications regarding this

Screen.Recording.2024-10-29.at.2.38.43.PM.mov

@Matvey-Kuk
Copy link
Contributor

@Mubashirshariq thank you for the contribution! The core of the codebase is at good quality, but the UI and some UX decisions confuse me. I'm going to close the PR and proceed with the bounty payment via your GH sponsorship. @VladimirFilonov will take your codebase and continue working on it in order to bring it up to the UX standards we have.

@Matvey-Kuk Matvey-Kuk closed this Oct 29, 2024
@Matvey-Kuk
Copy link
Contributor

Screenshot 2024-10-29 at 15 53 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ™‹ Bounty claim size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Runbooks queried by GitHub and GitLab providers
5 participants