Allow blocks with zero transactions #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the class tree from the chain is not initialized yet (class_commitment = Felt::Zero), Pathfinder will deliver that field with a None. This situation was handled.
Besides, the previous and current root hash from the class tree was taken from the storage proofs since they will be present always. Previous approach relied on class proof but in order to get them, it was necessary to have transactions in both blocks. Therefore, this PR allows SNOS to process blocks with zero transactions.
Replacing: #418
Issue Number: N/A
Type
Description
Breaking changes?