Perf epns

[shramee]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Testing
• Other (please describe):

What are the changes in the behavior?

1. Number of affected tests: 63
2. The largest improvements were in the neg_3 utility tests, with nearly 40% reduction in steps
3. BLS12_381 MSM (Multi-Scalar Multiplication) tests showed consistent improvements around 33%
4. Average improvement across all changed tests: 23.77%

Top 5 most improved tests:

1. garaga::utils::neg_3::tests::test_scalar_to_epns:

   • Change: 16,622 steps -> 9,986 steps
   • Improvement: 39.92%

2. garaga::utils::neg_3::tests::test_scalar_to_epns_single:

   • Change: 5,326 steps -> 3,209 steps
   • Improvement: 39.75%

3. garaga::tests::msm_tests::msm_tests::test_msm_BLS12_381_12P:

   • Change: 138,245 steps -> 92,206 steps
   • Improvement: 33.30%

4. garaga::tests::msm_tests::msm_tests::test_msm_BLS12_381_11P:

   • Change: 126,070 steps -> 84,131 steps
   • Improvement: 33.27%

5. garaga::tests::msm_tests::msm_tests::test_msm_BLS12_381_10P:

   • Change: 113,502 steps -> 75,813 steps
   • Improvement: 33.21%

Does this introduce a breaking change?

• Yes
• No

Other information

Might be nicer as separate commit for separation of optims.

[feltroidprime]

For the failing E2e test, simply replace the class hash you see in the error in the CI here https://github.com/keep-starknet-strange/garaga/actions/runs/12569635626/job/35038768468?pr=280#step:8:81 which has changed as result of the neg_3 changes.

(you can run it locally replicating

garaga/.github/workflows/e2e.yml

Lines 42 to 49 in fdffae4

	- name: Install dependencies
	run: make setup
	- name: Install devnet
	run: ./tests/contracts_e2e/install_devnet.sh
	- name: Run tests
	run: source venv/bin/activate && pytest -s -x tests/contracts_e2e/e2e_test.py

)

garaga/hydra/garaga/starknet/groth16_contract_generator/generator.py

Line 11 in fdffae4

ECIP_OPS_CLASS_HASH = 0x684D2756A4440C190A5FE54E367C0ABE33AEFA75084DEC2FFFC791B620C80E3

[feltroidprime]

Also dont forget to do a make rewrite after changing the class hash and commit to the changes

[shramee]

I'm getting some errors doing make rewrite

(venv) ➜  garaga git:(perf-epns) ✗ make rewrite
./tools/make/rewrite.sh
Traceback (most recent call last):
  File "/Users/shramee/www/starknet/garaga/hydra/garaga/starknet/honk_contract_generator/generator_honk.py", line 5, in <module>
    from garaga.definitions import CurveID
ModuleNotFoundError: No module named 'garaga'
Error in generator_honk.py
make: *** [rewrite] Error 1

⚠️ But I've updated the classhashes at other places reflexively.

[feltroidprime]

I'm getting some errors doing make rewrite

(venv) ➜  garaga git:(perf-epns) ✗ make rewrite
./tools/make/rewrite.sh
Traceback (most recent call last):
  File "/Users/shramee/www/starknet/garaga/hydra/garaga/starknet/honk_contract_generator/generator_honk.py", line 5, in <module>
    from garaga.definitions import CurveID
ModuleNotFoundError: No module named 'garaga'
Error in generator_honk.py
make: *** [rewrite] Error 1

⚠️ But I've updated the classhashes at other places reflexively.

I suggest to rm the venv/ folder, do a make setup again and scan for errors there if any, then activate the venv and retry make rewrite

[feltroidprime]

For the last error we need to replace

garaga/src/contracts/risc0_sample_app/fibonacci_sequencer/src/lib.cairo

Lines 13 to 14 in fdffae4

	pub const RISC_ZERO_VERIFIER_CLASS_HASH: felt252 =
	0x7f3157e83dc0d636c462c77fd8f309351b4a2c710f9a23a44305830a29b0b27;

by the new class hash of the risc0 verifier : 0x11c3cd9b36eb302d4b5a27a79f78d065c783995000cfe571f60408d11708dc4 https://github.com/keep-starknet-strange/garaga/actions/runs/12569877475/job/35039093457?pr=280#step:8:337

and it should be good

its a bit annoying but at least everything is in sync

Thank you

[shramee]

Thanks!
Done. make setup thing didn't wanna work for me. My Python c bindings are probably fucked up.