Fix the client when used with guzzle 7.9 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guzzle 7.9 introduces stricter checks on the protocol version. This protocol version is configured through the `version` config option. As the whole KeenIOClient config was passed to the instantiated Guzzle Client, this broke things because the version of the keen service was passed to Guzzle as the version config as well, while totally unrelated. The updated logic removes all config options corresponding to the KeenIOClient from the options passed to the Guzzle client.
|
@michalpierog Hi. Is there any chance to get this merged (and released) ? |
michalpierog
approved these changes
Aug 26, 2024
|
@stof Hi, the version https://github.com/keenlabs/KeenClient-PHP/releases/tag/v2.9.0 was released. Thanks for your contribution. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guzzle 7.9 introduces stricter checks on the protocol version. This protocol version is configured through the
versionconfig option. As the whole KeenIOClient config was passed to the instantiated Guzzle Client, this broke things because the version of the keen service was passed to Guzzle as the version config as well, while totally unrelated. The updated logic removes all config options corresponding to the KeenIOClient from the options passed to the Guzzle client.