Refactoring and cleanup #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PEP 8 error E401 ("multiple imports on one line").
Fixes PEP 8 error E713 ("test for membership should be 'not in'").
Fixes PEP 8 errors E201, E202, E211 (all about whitespace), and E701
("multiple statements on one line (colon)").
Put every keyword argument to the parser on a separate line to ease visual scanning.
This allows the suffixes to be specified as a set instead of a list, which would be a better semantic fit in this case.
This could save a bit of memory, too. Count files manually as the return value of the function has become a generator.
homeworkprod
force-pushed
the
homeworkprod-refactoring
branch
from
b71ea3b to
bdfdeae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kevin,
please find attached a number of patches to clean up and modernize the code a bit. The commits are quite small and should be rather easy to review.
Unfortunately, there are no tests yet, so I had to do test manually.
It might be worthwhile to define which Python versions are supported at all (for example,
yield fromwould make things a bit clearer). It might even be okay to drop Python 2 support altogether.What confused me a bit is that the source states the version to be 1.5.6, but Debian "stretch" already contains 1.5.7(-1). Seems like an oversight, since there is a tag for 1.5.7.
I have extracted a "constant" so the version number is visible right at the top rather than buried in the code.
Please let me know what you think.