Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a few PHP warnings #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing a few PHP warnings #107

wants to merge 2 commits into from

Conversation

rdwebdesign
Copy link
Contributor

@rdwebdesign rdwebdesign commented Dec 25, 2021 •
edited
Loading

This PR fix the warning received when the code (between lines 66 and 89) calls new inside addDataImpl().
Example:

    $this->addDataImpl(new QRNumber($data));

Also fixes the PHP Notice: A non well formed numeric value encountered... received when the code for printSVG() encounters a string where a numeric type is expected.

@rdwebdesign
Avoid PHP notice
8347448 
Avoid the "PHP Notice:  A non well formed numeric value encountered..." message, using the right type.
@rdwebdesign
Avoid PHP warning "pass-by-reference"
247e591
@rdwebdesign
Copy link
Contributor Author

@kazuhikoarase

Do you need more information about the fixed code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rdwebdesign