Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ppc64le and riscv64 #5

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

Desiki-high
Copy link

@Desiki-high Desiki-high commented Dec 12, 2023

Ref: dragonflyoss/nydus#1510.

Add BASE_MAGIC_ID in ppc64le and riscv64 archs.

Add `BASE_MAGIC_ID` in ppc64le and riscv64 archs.

Signed-off-by: Yadong Ding <[email protected]>
@imeoer
Copy link

imeoer commented Dec 12, 2023

Maybe we need also to add the test jobs for powerpc64 and riscv64 in github action.

@Desiki-high
Copy link
Author

Maybe we need also to add the test jobs for powerpc64 and riscv64 in github action.

Add test in amd64, arm64, ppc64le, riscv64.

Add test in amd64, arm64, ppc64le, riscv64.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high
Copy link
Author

PTAL @bergwolf, Thanks.

Copy link

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better contribute it to https://github.com/firecracker-microvm/firecracker/tree/main/src/snapshot as well, but it seems that firecracker doesn't support ppc64le and riscv64 yet.

@Desiki-high
Copy link
Author

We'd better contribute it to https://github.com/firecracker-microvm/firecracker/tree/main/src/snapshot as well, but it seems that firecracker doesn't support ppc64le and riscv64 yet.

I will try it, maybe the maintainers of https://github.com/firecracker-microvm/firecracker have some other considerations.

@Desiki-high
Copy link
Author

I have contributed it to https://github.com/firecracker-microvm/firecracker in firecracker-microvm#4319. Can we merge this and release it first? Because firecracker doesn't support ppc64le and riscv64, we need this. cc @imeoer .

@Desiki-high
Copy link
Author

Desiki-high commented Dec 13, 2023

See firecracker-microvm#4319 (comment), we can only use this in our fork crate.

@imeoer
Copy link

imeoer commented Dec 15, 2023

@bergwolf It seems the CI hang on "Waiting for status to be reported", is the setting correct?

@jiangliu
Copy link

/test

@imeoer imeoer merged commit 7f1947a into kata-containers:main Dec 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants