fix(train.py): mfu estimation to respect CPU-GPU sync point #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the mfu timing measurement was taken before the CPU-GPU sync point at every iter. The resulting
running_mfu
:log_interval = 1
.log_interval > 1
.log_interval
speeds up training (it usually does not).See diagrams below.
log_interval
= 1log_interval
= 2Note that
t3 - t2
is discarded. Onlyt2 - t1
andt4 - t3
etc contribute torunning_mfu
.