Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade net version to 8. #351

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Upgrade net version to 8. #351

merged 10 commits into from
Feb 19, 2024

Conversation

andy840119
Copy link
Member

Upgrade the .net version from 6 to 8
Also, upgrade the osu-framework-related package to the latest.
CI/CD will use the latest net version also.

@andy840119 andy840119 added the dependencies Pull requests that update a dependency file label Feb 19, 2024
@andy840119
Fix warning CS0618: 'AVAudioSession.CategoryRecord' is obsolete: 'Use…
97471d4 
… 'AVAudioSessionCategory' enum values instead.' [/Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.iOS/osu.Framework.Microphone.iOS.csproj]
@andy840119
Upgrade the props from osu-framework.
6fc3ca1
@andy840119
Follow the osu-framework change the fix the "CSC : error EnableGenera…
02b6484 
…teDocumentationFile: Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640) [/home/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone/osu.Framework.Microphone.csproj]" error

Also see:
https://github.com/ppy/osu-framework/pull/6169/files
@andy840119
Add more configs for the android project to fix the "error MSB4121: T…
bf927ad 
…he project configuration for project "osu.Framework.Microphone.Android" was not specified in the solution file for the solution configuration "Release|Any CPU". [/home/runner/work/osu-framework-microphone/osu-framework-microphone/osu-framework-microphone.Desktop.slnf]" issue.
@andy840119
Copy link
Member Author

image

CI 讓我過吧
我想睡覺了
求求你好心人

@andy840119
Copy link
Member Author

Can fix the iOS build issue later.

Here's the damn log:

MSBuild version 1[7](https://github.com/karaoke-dev/osu-framework-microphone/actions/runs/7962742060/job/21736848400?pr=351#step:5:8).9.4+90725d0[8](https://github.com/karaoke-dev/osu-framework-microphone/actions/runs/7962742060/job/21736848400?pr=351#step:5:9)d for .NET
  Determining projects to restore...
  Restored /Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone/osu.Framework.Microphone.csproj (in 16.08 sec).
  Restored /Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.iOS/osu.Framework.Microphone.iOS.csproj (in 16.08 sec).
  Restored /Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.Tests.iOS/osu.Framework.Microphone.Tests.iOS.csproj (in 16.41 sec).
/Users/runner/.dotnet/packs/Microsoft.iOS.Sdk/17.2.8022/tools/msbuild/iOS/Xamarin.Shared.targets(1805,3): error : No valid iOS code signing keys found in keychain. You need to request a codesigning certificate from https://developer.apple.com./ [/Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.Tests.iOS/osu.Framework.Microphone.Tests.iOS.csproj]
/Users/runner/.dotnet/packs/Microsoft.iOS.Sdk/17.2.8022/tools/msbuild/iOS/Xamarin.Shared.targets(1805,3): error :          [/Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.Tests.iOS/osu.Framework.Microphone.Tests.iOS.csproj]
  osu.Framework.Microphone -> /Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone/bin/Debug/net8.0/osu.Framework.Microphone.dll
  osu.Framework.Microphone.iOS -> /Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.iOS/bin/Debug/net8.0-ios/osu.Framework.Microphone.iOS.dll

Build FAILED.

/Users/runner/.dotnet/packs/Microsoft.iOS.Sdk/17.2.8022/tools/msbuild/iOS/Xamarin.Shared.targets(1805,3): error : No valid iOS code signing keys found in keychain. You need to request a codesigning certificate from https://developer.apple.com. [/Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.Tests.iOS/osu.Framework.Microphone.Tests.iOS.csproj]
/Users/runner/.dotnet/packs/Microsoft.iOS.Sdk/17.2.8022/tools/msbuild/iOS/Xamarin.Shared.targets(1805,3): error :          [/Users/runner/work/osu-framework-microphone/osu-framework-microphone/osu.Framework.Microphone.Tests.iOS/osu.Framework.Microphone.Tests.iOS.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:24.[13](https://github.com/karaoke-dev/osu-framework-microphone/actions/runs/7962742060/job/21736848400?pr=351#step:5:14)
Error: Process completed with exit code 1.

@andy840119 andy840119 merged commit 137bbce into karaoke-dev:master Feb 19, 2024
12 of 13 checks passed
@andy840119 andy840119 deleted the upgrade-net-version-to-8 branch February 19, 2024 16:43
@andy840119 andy840119 mentioned this pull request Feb 19, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119