Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code quality CI has "Partial class with single part in class.cs" issue. #338

Merged

Conversation

andy840119
Copy link
Member

Fix issue #336.

make the partial issue as hint for fixing the issue:
ppy/osu-framework@9f3bc03
@andy840119 andy840119 added bug Something isn't working package update any package. labels Oct 2, 2023
Should be file-scope namespace and can use "new()" directly without explicitly type.
@andy840119
Copy link
Member Author

Nice

@andy840119 andy840119 merged commit f046d17 into karaoke-dev:master Oct 2, 2023
10 checks passed
@andy840119 andy840119 deleted the fix-code-quality-ci-broken branch October 2, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package update any package. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant