Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ppy.osu.Framework from 2023.1201.1 to 2023.1213.0 #423

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2023

Bumps ppy.osu.Framework from 2023.1201.1 to 2023.1213.0.

Release notes

Sourced from ppy.osu.Framework's releases.

2023.1213.0

Breaking changes

IParseable.Parse() has received an IFormatProvider argument

This is provided to better treat input when typed by end users, by allowing the ability to respect their regional number settings.

Existing usages of IParseable.Parse() should pass CultureInfo.InvariantCulture to preserve behaviour, including usages of IBindable.Parse():

  Bindable<int> bindable = new Bindable<int>();
- bindable.Parse(5);
+ bindable.Parse(5, CultureInfo.InvariantCulture);

DrawNode.Draw() is no longer exposed publicly

Draw() is now protected to match the signature of DrawOpaqueInternal(). DrawNodes which draw others no need to do so via a separate (provided) method.

- public override void Draw(IRenderer renderer)
+ protected override void Draw(IRenderer renderer)
  {
      base.Draw(renderer);


other.Draw(renderer);





DrawOther(other, renderer);

}

Dropdown requires a search bar to be implemented

All Dropdowns may now be searched, which requires them to implement a search bar component. Sample implementation:

public partial class MyDropdownHeader : DropdownHeader
{
    protected override DropdownSearchBar CreateSearchBar() => new MyDropdownSearchBar();
public partial class MyDropdownSearchBar : DropdownSearchBar
{
    protected override void PopIn() =&gt; this.FadeIn();
protected override void PopOut() =&amp;gt; this.FadeOut();

protected override TextBox CreateTextBox() =&amp;gt; new MyTextBox
{
    PlaceholderText = &amp;quot;type to search&amp;quot;
};

}

</tr></table>

... (truncated)

Commits
  • ba569bf Merge pull request #6072 from frenzibyte/dropdown-search
  • d5c2e65 Enforce centre-left anchor/origin on placeholder text
  • fe0b532 Remove unused using directive
  • 1876a71 Update test border caret
  • 0958965 Fix automatic textbox font size broken by layout changes
  • bb9f45e Fix compile error
  • 4e543e0 Merge branch 'master' into dropdown-search
  • 393a87d Fix text box layout when using arbitrary font sizes
  • 67e11cc Merge pull request #6066 from OliBomby/betterer-builder
  • e7c7397 Rename some members for understanding
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ppy.osu.Framework](https://github.com/ppy/osu-framework) from 2023.1201.1 to 2023.1213.0.
- [Release notes](https://github.com/ppy/osu-framework/releases)
- [Commits](ppy/osu-framework@2023.1201.1...2023.1213.0)

---
updated-dependencies:
- dependency-name: ppy.osu.Framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 14, 2023
@andy840119
Copy link
Member

Note the api breaking change:
https://github.com/ppy/osu-framework/pull/6073/files

@andy840119 andy840119 merged commit 276fe78 into master Dec 14, 2023
2 checks passed
@andy840119 andy840119 deleted the dependabot/nuget/ppy.osu.Framework-2023.1213.0 branch December 14, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant