Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to get the full-size of the character. #197

Conversation

andy840119
Copy link
Member

It's a way to fix issue #194 without having something called "GetTimeTagPosition" because it'a weird in the LyricSpriteText.

Also, getCharacterRectangle in the LyricSpriteText use the tricky way to calculate the size.
Should fix that eventually.

@andy840119 andy840119 added the bug Something isn't working label May 16, 2022
… size only.

For now we just make a similar value.
Should get the real value eventually.
@andy840119 andy840119 force-pushed the fix-should-get-character-with-full-size branch from 3ceec63 to d4909b4 Compare May 16, 2022 16:50
@andy840119 andy840119 merged commit cb483d9 into karaoke-dev:master May 16, 2022
@andy840119 andy840119 deleted the fix-should-get-character-with-full-size branch May 16, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant