Should re-calculate the transforms if change the shader in the karaoke sprite text. #179

andy840119 · 2022-05-06T14:44:05Z

Closes issue #178

What's done in this PR:

Make the karaoke text in the center in the test case.
Adjust the test case to make it able to show the trigger transform count.
Should trigger the transform to be re-calculate if shader, text, font, alignment and spacing changed.
Reduce initial transform trigger count.

Now it's able to show how many time refresh state has been triggered.

…, alignment and spacing changed.

So we should make sure that it will be triggered at least once.

andy840119 added 4 commits May 6, 2022 21:52

Adjust the test case to make the text in the center.

8530586

Adjust the damn test case.

2ee1b18

Now it's able to show how many time refresh state has been triggered.

Should trigger the transform to be re-calculate if shader, text, font…

90e06b7

…, alignment and spacing changed.

Because refresh state only triggered if some property changed.

23cf750

So we should make sure that it will be triggered at least once.

andy840119 added bug Something isn't working code quality labels May 6, 2022

andy840119 self-assigned this May 6, 2022

pull-request-size bot added the size/L label May 6, 2022

andy840119 merged commit 44cbc12 into karaoke-dev:master May 6, 2022

andy840119 deleted the add-test-case-for-checking-the-invalidate branch May 6, 2022 14:46

Provide feedback