should only create shard data once because drawable node will create …

…three times.

osu.Framework.Font.Tests/Visual/Shaders/ShaderTestScene.cs

@@ -73,6 +73,9 @@ protected class TestShaderContainer : Container, IMultiShaderBufferedDrawable
 
             private readonly List<IShader> shaders = new();
 
+            // todo: should have a better way to let user able to customize formats?
+            private readonly MultiShaderBufferedDrawNodeSharedData sharedData = new();
+
             public IReadOnlyList<IShader> Shaders
             {
                 get => shaders;
@@ -95,9 +98,8 @@ private void load(ShaderManager shaders)
                 RoundedTextureShader = shaders.Load(VertexShaderDescriptor.TEXTURE_2, FragmentShaderDescriptor.TEXTURE_ROUNDED);
             }
 
-            // todo: should have a better way to let user able to customize formats?
             protected override DrawNode CreateDrawNode()
-                => new TestShaderContainerShaderEffectDrawNode(this, new MultiShaderBufferedDrawNodeSharedData());
+                => new TestShaderContainerShaderEffectDrawNode(this, sharedData);
 
             /// <summary>
             /// <see cref="BufferedDrawNode"/> to apply <see cref="IShader"/>.

osu.Framework.Font/Graphics/Sprites/KaraokeSpriteText.cs

@@ -26,6 +26,9 @@ public class KaraokeSpriteText : KaraokeSpriteText<LyricSpriteText>
         private readonly MaskingContainer<T> backLyricTextContainer;
         private readonly T backLyricText;
 
+        // todo: should have a better way to let user able to customize formats?
+        private readonly MultiShaderBufferedDrawNodeSharedData sharedData = new MultiShaderBufferedDrawNodeSharedData();
+
         public IShader TextureShader { get; private set; }
         public IShader RoundedTextureShader { get; private set; }
 

osu.Framework.Font/Graphics/Sprites/KaraokeSpriteText_DrawNode.cs

@@ -18,9 +18,8 @@ protected override Quad ComputeScreenSpaceDrawQuad()
             return ToScreenSpace(newRectangle);
         }
 
-        // todo: should have a better way to let user able to customize formats?
         protected override DrawNode CreateDrawNode()
-            => new KaraokeSpriteTextShaderEffectDrawNode(this, new MultiShaderBufferedDrawNodeSharedData());
+            => new KaraokeSpriteTextShaderEffectDrawNode(this, sharedData);
 
         /// <summary>
         /// <see cref="BufferedDrawNode"/> to apply <see cref="IShader"/>.

osu.Framework.Font/Graphics/Sprites/LyricSpriteText.cs

@@ -27,6 +27,9 @@ public partial class LyricSpriteText : Drawable, IMultiShaderBufferedDrawable, I
         private const float default_text_size = 48;
         private static readonly char[] default_never_fixed_width_characters = { '.', ',', ':', ' ' };
 
+        // todo: should have a better way to let user able to customize formats?
+        private readonly MultiShaderBufferedDrawNodeSharedData sharedData = new MultiShaderBufferedDrawNodeSharedData();
+
         [Resolved]
         private FontStore store { get; set; }
 

osu.Framework.Font/Graphics/Sprites/LyricSpriteText_DrawNode.cs

@@ -21,9 +21,8 @@ protected override Quad ComputeScreenSpaceDrawQuad()
             return ToScreenSpace(newRectangle);
         }
 
-        // todo: should have a better way to let user able to customize formats?
         protected override DrawNode CreateDrawNode()
-            => new LyricSpriteTextShaderEffectDrawNode(this, new MultiShaderBufferedDrawNodeSharedData());
+            => new LyricSpriteTextShaderEffectDrawNode(this, sharedData);
 
         /// <summary>
         /// <see cref="BufferedDrawNode"/> to apply <see cref="IShader"/>.