Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename remaining romaji to romanisation. #2196

Merged
merged 10 commits into from
Mar 17, 2024
Merged

Rename remaining romaji to romanisation. #2196

merged 10 commits into from
Mar 17, 2024

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Mar 17, 2024 •
edited
Loading

As title.
Last part of #2145.

@andy840119 andy840119 added the code quality Improve code quality. label Mar 17, 2024
@andy840119 andy840119 added this to the 2024.0505 milestone Mar 17, 2024
@andy840119
Copy link
Member Author

image
All test passed in local.

@andy840119 andy840119 merged commit 2e0eedd into karaoke-dev:master Mar 17, 2024
3 of 4 checks passed
@andy840119 andy840119 deleted the rename-from-romaji-to-romanization branch March 17, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality Improve code quality. size/L
Projects
None yet
Milestone
2024.0406
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119