New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Romani to romanization in the lyric editor. #2183

Merged

andy840119 merged 8 commits into karaoke-dev:master from andy840119:romani-to-reoamnzation-in-lyric-editor

Mar 10, 2024

Member

andy840119 commented Mar 10, 2024

Missing part of #2182.

andy840119 added 8 commits

March 10, 2024 16:11


          Romaji -> Romanisation in the LyricEditorMode.

0c77492


          Romaji -> Romanisation in the state.

4503e90


          Romaji -> Romanisation in the settings.

b082354


          Rename the property in the state.

db81fee


          RomajiTagSettings -> RomanisationSettings.

ef456f9


          CheckLyricTimeTagRomaji -> CheckLyricRomanisation

caafa48


          Remove romaji wording.

7fbc245


          This property is not for the ruby/romanisation-related property only.

2c69c2b

andy840119 added code quality LyricMaker labels

andy840119 added this to the 2024.0505 milestone

pull-request-size bot added the size/L label

andy840119 merged commit e3fb767 into karaoke-dev:master

4 checks passed

andy840119 deleted the romani-to-reoamnzation-in-lyric-editor branch

March 10, 2024 08:34

Member Author

andy840119 commented Mar 17, 2024

Related to #2145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality LyricMaker size/L