Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Romanization -> Romanisation #2180

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Romanization -> Romanisation #2180

merged 3 commits into from
Mar 3, 2024

Conversation

andy840119
Copy link
Member

Change the English wording to UK wording.
Like lazer use colour instead of color.

@andy840119 andy840119 added code quality Improve code quality. localization Translation related. labels Mar 3, 2024
@andy840119 andy840119 added this to the 2024.0505 milestone Mar 3, 2024
@andy840119
Copy link
Member Author

Change the wording because Lazer already using it for those non-native song name.

see:
https://github.com/ppy/osu/pull/16273/files

@andy840119 andy840119 merged commit f8da2b2 into karaoke-dev:master Mar 3, 2024
4 checks passed
@andy840119 andy840119 deleted the rename-from-romanization-to-romanisation branch March 3, 2024 11:04
@andy840119
Copy link
Member Author

Related to #2145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality Improve code quality. localization Translation related. size/L
Projects
None yet
Milestone
2024.0406
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119