Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change romaji generator return type from array to the dictionaty. #2078

Conversation

andy840119
Copy link
Member

Improvement of #2077.
Change the return type to dictionary for easier to find the result by time-tag.

@andy840119 andy840119 added code quality Improve code quality. generator Auto-generator labels Jul 23, 2023
@andy840119 andy840119 added this to the 2023.0808 milestone Jul 23, 2023
@andy840119 andy840119 merged commit 66db91a into karaoke-dev:master Jul 23, 2023
@andy840119 andy840119 deleted the change-the-romaji-generator-type-to-dictionary branch July 23, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve code quality. generator Auto-generator size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant