Here's no need to read the skin from default skin.

karaoke-dev · Oct 10, 2022 · f00aa30 · f00aa30
1 parent c004c84
commit f00aa30
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeLegacySkinTransformer.cs b/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeLegacySkinTransformer.cs
@@ -15,14 +15,14 @@ namespace osu.Game.Rulesets.Karaoke.Skinning.Legacy
     public class KaraokeLegacySkinTransformer : LegacySkinTransformer
     {
         private readonly Lazy<bool> isLegacySkin;
-        private readonly KaraokeBeatmapSkin defaultKaraokeSkin;
+        private readonly KaraokeBeatmapSkin karaokeSkin;
 
         public KaraokeLegacySkinTransformer(ISkin source, IBeatmap beatmap)
             : base(source)
         {
             // we should get config by default karaoke skin.
             // if has resource or texture, then try to get from legacy skin.
-            defaultKaraokeSkin = new KaraokeBeatmapSkin(new SkinInfo(), new InternalSkinStorageResourceProvider("Default"));
+            karaokeSkin = new KaraokeBeatmapSkin(new SkinInfo(), new InternalSkinStorageResourceProvider("Default"));
             isLegacySkin = new Lazy<bool>(() => GetConfig<SkinConfiguration.LegacySetting, decimal>(SkinConfiguration.LegacySetting.Version) != null);
         }
 
@@ -82,10 +82,7 @@ public KaraokeLegacySkinTransformer(ISkin source, IBeatmap beatmap)
         }
 
         public override IBindable<TValue>? GetConfig<TLookup, TValue>(TLookup lookup)
-        {
-            var config = defaultKaraokeSkin.GetConfig<TLookup, TValue>(lookup);
-            return config ?? base.GetConfig<TLookup, TValue>(lookup);
-        }
+            => karaokeSkin.GetConfig<TLookup, TValue>(lookup);
 
         // it's a temp class for just getting SkinnableTarget.MainHUDComponents
         private class TempLegacySkin : LegacySkin