Skip to content

Commit

Permalink
fix compile warning.
Browse files Browse the repository at this point in the history
  • Loading branch information
andy840119 committed Nov 9, 2020
1 parent e7fd774 commit efa143c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ protected override void ApplyLayout(KaraokeLayout layout)
Padding = new MarginPadding(0);
}

protected override void UpdateStateTransforms(ArmedState state)
protected override void UpdateStartTimeStateTransforms()
{
// Do not fade-in / fade-out while changing armed state.
}
Expand Down
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Karaoke/Mods/KaraokeModHiddenNote.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public override void ApplyToDrawableHitObjects(IEnumerable<DrawableHitObject> dr
base.ApplyToDrawableHitObjects(drawables);
}

protected override void ApplyHiddenState(DrawableHitObject hitObject, ArmedState state)
protected override void ApplyNormalVisibilityState(DrawableHitObject hitObject, ArmedState state)
{
if (!(hitObject is DrawableNote note))
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ protected override void UpdateInitialTransforms()
{
}

protected override void UpdateStateTransforms(ArmedState state)
protected override void UpdateStartTimeStateTransforms()
{
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,6 @@ protected DrawableKaraokeHitObject(KaraokeHitObject hitObject)

protected sealed override double InitialLifetimeOffset => HitObject.TimePreempt;

protected override void UpdateStateTransforms(ArmedState state)
{
base.UpdateStateTransforms(state);

switch (state)
{
case ArmedState.Idle:
// Manually set to reduce the number of future alive objects to a bare minimum.
LifetimeStart = HitObject.StartTime - HitObject.TimePreempt;
break;
}
}

protected override JudgementResult CreateResult(Judgement judgement) => new KaraokeJudgementResult(HitObject, judgement);
}
}
4 changes: 2 additions & 2 deletions osu.Game.Rulesets.Karaoke/Objects/Drawables/DrawableLyric.cs
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ protected override void CheckForResult(bool userTriggered, double timeOffset)
}
}

protected override void UpdateStateTransforms(ArmedState state)
protected override void UpdateStartTimeStateTransforms()
{
base.UpdateStateTransforms(state);
base.UpdateStartTimeStateTransforms();

using (BeginDelayedSequence(HitObject.Duration, true))
{
Expand Down

0 comments on commit efa143c

Please sign in to comment.