Replace string into char.

karaoke-dev · Jul 21, 2024 · df0a33f · df0a33f
1 parent 1fd4bd8
commit df0a33f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...ts.Karaoke.Tests/Editor/Generator/Lyrics/Romanisation/RomanisationGenerateResultHelper.cs b/...ts.Karaoke.Tests/Editor/Generator/Lyrics/Romanisation/RomanisationGenerateResultHelper.cs
@@ -25,7 +25,7 @@ public static KeyValuePair<TimeTag, RomanisationGenerateResult> ParseRomanisatio
     {
         var result = new RomanisationGenerateResult
         {
-            FirstSyllable = str.StartsWith("^", StringComparison.Ordinal),
+            FirstSyllable = str.StartsWith('^'),
             RomanisedSyllable = str.Replace("^", ""),
         };
 

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Helper/TestCaseTagHelper.cs b/osu.Game.Rulesets.Karaoke.Tests/Helper/TestCaseTagHelper.cs
@@ -114,7 +114,7 @@ public static TimeTag ParseTimeTag(string? str)
             var state = result.GetGroupValue<string>("state") == "start" ? TextIndex.IndexState.Start : TextIndex.IndexState.End;
             int? time = result.GetGroupValue<int?>("time");
             string? text = result.GetGroupValue<string?>("text");
-            bool? firstSyllable = text?.StartsWith("^");
+            bool? firstSyllable = text?.StartsWith('^');
 
             return new TimeTag(new TextIndex(index, state), time)
             {

diff --git a/osu.Game.Rulesets.Karaoke/Beatmaps/Formats/KaraokeLegacyBeatmapDecoder.cs b/osu.Game.Rulesets.Karaoke/Beatmaps/Formats/KaraokeLegacyBeatmapDecoder.cs
@@ -65,7 +65,7 @@ protected override void ParseLine(Beatmap beatmap, Section section, string line)
             // add translation queue
             translations.Add(line);
         }
-        else if (line.StartsWith("@", StringComparison.Ordinal))
+        else if (line.StartsWith('@'))
         {
             // Remove @ in time tag and add into lrc queue
             lrcLines.Add(line[1..]);
@@ -127,7 +127,7 @@ private void processNotes(Beatmap beatmap, IList<string> lines)
                 var defaultNote = defaultNotes[i];
 
                 // Support multi note in one time tag, format like ([1;0.5;か]|1#|...)
-                if (!note.StartsWith("(", StringComparison.Ordinal) || !note.EndsWith(")", StringComparison.Ordinal))
+                if (!note.StartsWith('(') || !note.EndsWith(')'))
                 {
                     // Process and add note
                     applyNote(defaultNote, note);
@@ -147,7 +147,7 @@ private void processNotes(Beatmap beatmap, IList<string> lines)
                         string? ruby = defaultNote.RubyText?.ElementAtOrDefault(j).ToString();
 
                         // Format like [1;0.5;か]
-                        if (note.StartsWith("[", StringComparison.Ordinal) && note.EndsWith("]", StringComparison.Ordinal))
+                        if (note.StartsWith('[') && note.EndsWith(']'))
                         {
                             string[] rubyNoteProperty = note.Replace("[", string.Empty).Replace("]", string.Empty).Split(';');